Publish snapshots to Sonatype Snapshot repository #17
Conversation
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
force-pushed
the
maven-publish
branch
from
fa5caad to
489c562
Compare
| export SONATYPE_PASSWORD=$(aws secretsmanager get-secret-value --secret-id maven-snapshots-password --query SecretString --output text) | ||
| echo "::add-mask::$SONATYPE_USERNAME" | ||
| echo "::add-mask::$SONATYPE_PASSWORD" | ||
| ./gradlew publishMavenJavaPublicationToSnapshotsRepository |
There was a problem hiding this comment.
Don't we need to do: ./gradlew publishPluginZipPublicationToSnapshotsRepository? Ref
ml-commons does the same.
There was a problem hiding this comment.
No, this is not a plugin. It's a JAR file.
The gradle task is mavenJava:
opensearch-remote-metadata-sdk/build.gradle
Line 150 in 6c77e4b
ml-commons also publishes a shadow jar in the same line you linked, as does common-utils which we are logically more similar to.
I wouldn't mind having a shadow vs. normal jar discussion and switching to that later if there's a strong reason to, but that's an extra level of complexity right now and I'm really trying to get this published in some way to unblock plugin work. 2.19.0 code freeze is 25 days away so any unnecessary configuration at this point is risking feature delivery.
|
@opensearch-project/engineering-effectiveness @peterzhuamazon I think you guys need to review the PR too to create the IAM role to fetch the secret according to this |
It's being tracked separately: |
dbwiddis
changed the title
Description
Resubmission of #12, closed when I had to delete my repo when this one was flipped private
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.